Skip to content

Merge all intermediate revisions when props accumulation is not guaranteed (#56914)#56914

Closed
j-piasecki wants to merge 1 commit into
facebook:mainfrom
j-piasecki:export-D105835162
Closed

Merge all intermediate revisions when props accumulation is not guaranteed (#56914)#56914
j-piasecki wants to merge 1 commit into
facebook:mainfrom
j-piasecki:export-D105835162

Conversation

@j-piasecki
Copy link
Copy Markdown
Contributor

@j-piasecki j-piasecki commented May 21, 2026

Summary:

Changelog: [ANDROID][FIXED] Fix commit branching dropping updates when enableAccumulatedUpdatesInRawPropsAndroid is not enabled.

Without enableAccumulatedUpdatesInRawPropsAndroid each shadow tree revision on Android carries only the props applied in that specific revision. To handle this properly, all intermediate revisions need to pass through the mounting layer so the platform is aware of all the props.

Reviewed By: rubennorte

Differential Revision: D105835162

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 21, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented May 21, 2026

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105835162.

@facebook-github-tools facebook-github-tools Bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels May 21, 2026
@meta-codesync meta-codesync Bot changed the title Merge all intermediate revisions when props accumulation is not guaranteed Merge all intermediate revisions when props accumulation is not guaranteed (#56914) May 21, 2026
j-piasecki added a commit to j-piasecki/react-native that referenced this pull request May 21, 2026
…nteed (facebook#56914)

Summary:

Changelog: [ANDROID][FIXED] Fix commit branching dropping updates when `enableAccumulatedUpdatesInRawPropsAndroid` is not enabled.

Without `enableAccumulatedUpdatesInRawPropsAndroid` each shadow tree revision on Android carries only the props applied in that specific revision. To handle this properly, all intermediate revisions need to pass through the mounting layer so the platform is aware of all the props.

Differential Revision: D105835162
@j-piasecki j-piasecki force-pushed the export-D105835162 branch 2 times, most recently from 4edca1b to 31c3ad4 Compare May 25, 2026 05:12
j-piasecki added a commit to j-piasecki/react-native that referenced this pull request May 25, 2026
…nteed (facebook#56914)

Summary:

Changelog: [ANDROID][FIXED] Fix commit branching dropping updates when `enableAccumulatedUpdatesInRawPropsAndroid` is not enabled.

Without `enableAccumulatedUpdatesInRawPropsAndroid` each shadow tree revision on Android carries only the props applied in that specific revision. To handle this properly, all intermediate revisions need to pass through the mounting layer so the platform is aware of all the props.

Reviewed By: rubennorte

Differential Revision: D105835162
…nteed (facebook#56914)

Summary:

Changelog: [ANDROID][FIXED] Fix commit branching dropping updates when `enableAccumulatedUpdatesInRawPropsAndroid` is not enabled.

Without `enableAccumulatedUpdatesInRawPropsAndroid` each shadow tree revision on Android carries only the props applied in that specific revision. To handle this properly, all intermediate revisions need to pass through the mounting layer so the platform is aware of all the props.

Reviewed By: rubennorte

Differential Revision: D105835162
@j-piasecki j-piasecki force-pushed the export-D105835162 branch from 31c3ad4 to d817dc9 Compare May 25, 2026 07:53
@meta-codesync meta-codesync Bot closed this in bcadeda May 25, 2026
@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @j-piasecki in bcadeda

When will my fix make it into a release? | How to file a pick request?

@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented May 25, 2026

This pull request has been merged in bcadeda.

@facebook-github-tools facebook-github-tools Bot added the Merged This PR has been merged. label May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants